feat(fleet): make dashboard key hints respect node state - #174
Merged
Conversation
The entries are built per node: start is offered where the board's read does not report the node running, stop where it does, and neither while an action is in flight. The keys are not gated - pressing one the hint hides still makes the call and shows the node's own answer on the status line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard's key help now shows start and stop only for the node where they would drive something, the way the keep and abandon entries already do.
Summary
startOffered,stopOffered) that read the board's current read of the node under the cursor, instead of a static list with only keep and abandon gateddashFooterHintspath; both screens pass their built line tofooterLinedocs/commands/fleet.mdcarries the same shown-only-where-they-drive-something wording as the keep rowImplementation details
The offer predicates live beside
keepOffered/canAborton the model and share a smallnodeRunningcheck (read OK and staterunning). Gating is display-only and deliberately does not touch the key handlers, so a start pressed on a running node is still refused by the engine and reported, matching the one-shot command's behaviour. OpenSpec changestate-aware-dashboard-keysrecords the spec delta and design.